Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): use resolveModuleNames TypeScript API to get resolved modules for test files #1784

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jul 7, 2020

Summary

Remove workaround in compiler-utils.ts and replace with resolveModuleNames from LanguageService API.

Fixes #1747

Test plan

Added unit tests. Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner July 7, 2020 15:19
@ahnpnl ahnpnl changed the title fix(compiler): use resolveModuleNames TypeScript API fix(compiler): use resolveModuleNames TypeScript API to get resolved modules for test files Jul 7, 2020
@coveralls
Copy link

coveralls commented Jul 7, 2020

Pull Request Test Coverage Report for Build 5295

  • 25 of 25 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.756%

Totals Coverage Status
Change from base Build 5294: -0.1%
Covered Lines: 1053
Relevant Lines: 1088

💛 - Coveralls

kulshekhar
kulshekhar previously approved these changes Jul 7, 2020
@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Jul 7, 2020

sorry I was trying to improve unit tests for the async writeFile. This PR is in final state now :)

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Jul 8, 2020

did a final push, noticed a debug log was wrong 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: With cached results, changes to type definitions are not detected
3 participants